fix: refresh DTF and token prices on the quote cadence - #39
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: refresh DTF and token prices on the quote cadence#39devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Patrick <patrick.mckelvy@reserve.org>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Deploying react-zapper with
|
| Latest commit: |
4d90180
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a34579b8.react-zapper.pages.dev |
| Branch Preview URL: | https://devin-1784923622-price-refre.react-zapper.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The USD value shown for the token being redeemed, and the price impact of every quote, was computed from a DTF price fetched once at widget mount and never refreshed, while the quote itself refreshed every
refreshRate(9s). Since 2.7.1 both legs' USD values andpriceImpact/truePriceImpactare derived from Reserve prices inapplyPricing, so a frozen DTF price directly skews what the user sees, and it gets worse the longer the widget stays open (Register setsrefetchOnWindowFocus: false, so nothing ever re-triggered the fetch).Both price queries now run on the quote's own cadence, so the two legs are always priced from the same moment: the
current/dtfquery inuse-index-basket.tsgainsrefetchInterval/staleTime=refreshRateAtom(9s default), andusePricemoves off its independent 30s/15s timers onto the same value.tests/price-refresh.test.tsxpins the cadence for both queries (fails without the change, passes with it). Version bumped to 2.7.3 — 2.7.2 was accidentally published from a direct push tomain, since reverted, so the next release number is 2.7.3.Link to Devin session: https://app.devin.ai/sessions/217c81a67bbd4cd381366a5adf7356d9
Requested by: @pmckelvy1